Skip to content
Snippets Groups Projects
Commit c358c625 authored by Wan-Teh Chang's avatar Wan-Teh Chang Committed by wm4
Browse files

pthread_frame: use better memory orders for frame progress


This improves commit 59c70227.

In ff_thread_report_progress(), the fast code path can load
progress[field] with the relaxed memory order, and the slow code path
can store progress[field] with the release memory order. These changes
are mainly intended to avoid confusion when one inspects the source code.
They are unlikely to have measurable performance improvement.

ff_thread_report_progress() and ff_thread_await_progress() form a pair.
ff_thread_await_progress() reads progress[field] with the acquire memory
order (in the fast code path). Therefore, one expects to see
ff_thread_report_progress() write progress[field] with the matching
release memory order.

In the fast code path in ff_thread_report_progress(), the atomic load of
progress[field] doesn't need the acquire memory order because the
calling thread is trying to make the data it just decoded visible to the
other threads, rather than trying to read the data decoded by other
threads.

In ff_thread_get_buffer(), initialize progress[0] and progress[1] using
atomic_init().

Signed-off-by: default avatarWan-Teh Chang <wtc@google.com>
Signed-off-by: default avatarAnton Khirnov <anton@khirnov.net>

Merges Libav commit 343e2833.

Signed-off-by: default avatarwm4 <nfxjfg@googlemail.com>
parent fb69a8e1
No related branches found
No related tags found
No related merge requests found
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment