Skip to content
Snippets Groups Projects
Commit c1847c93 authored by John Brooks's avatar John Brooks Committed by Michael Niedermayer
Browse files

Correct buffer handling for RTCP packets


Previous code could read 4 bytes past the end of the buffer on a RTCP_SR
packet or offset a pointer by an unchecked external value (payload_len),
though neither will reliably cause a crash or other misbehavior beyond
garbage timestamps.

Additionally, unknown RTCP packet types, even in compounded packets, are
now ignored as per RFC 3550 section 6.1, page 22, though currently this
only has any practical effect if a sender puts an unrecognized type
before RTCP_BYE in a compounded packet, or (incorrectly) does not put
RTCP_SR first.

Signed-off-by: default avatarJohn Brooks <john.brooks@bluecherry.net>
Signed-off-by: default avatarMichael Niedermayer <michaelni@gmx.at>
parent dc66951b
No related branches found
No related tags found
No related merge requests found
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment