Skip to content
Snippets Groups Projects
Commit a09bb3ba authored by Mans Rullgard's avatar Mans Rullgard
Browse files

lavc: avoid invalid memcpy() in avcodec_default_release_buffer()

When the buf and last pointers are equal, the FFSWAP() results
in an invalid call to memcpy() with same source and destination
on some targets.  Although assigning a struct to itself is valid
C99, gcc does not check for this before calling memcpy().
See http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32667



Signed-off-by: default avatarMans Rullgard <mans@mansr.com>
parent 3383a53e
No related branches found
No related tags found
No related merge requests found
...@@ -509,7 +509,8 @@ void avcodec_default_release_buffer(AVCodecContext *s, AVFrame *pic){ ...@@ -509,7 +509,8 @@ void avcodec_default_release_buffer(AVCodecContext *s, AVFrame *pic){
avci->buffer_count--; avci->buffer_count--;
last = &avci->buffer[avci->buffer_count]; last = &avci->buffer[avci->buffer_count];
FFSWAP(InternalBuffer, *buf, *last); if (buf != last)
FFSWAP(InternalBuffer, *buf, *last);
} }
for (i = 0; i < AV_NUM_DATA_POINTERS; i++) { for (i = 0; i < AV_NUM_DATA_POINTERS; i++) {
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment