Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
F
FFmpeg
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Container Registry
Model registry
Operate
Environments
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
libremedia
Tethys
FFmpeg
Commits
97bf7c03
Commit
97bf7c03
authored
12 years ago
by
Diego Biurrun
Browse files
Options
Downloads
Patches
Plain Diff
doc: git-howto: Leave reviewers time to react before pushing patches
parent
a903f8f0
No related branches found
Branches containing commit
No related tags found
Tags containing commit
No related merge requests found
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
doc/git-howto.texi
+7
-0
7 additions, 0 deletions
doc/git-howto.texi
with
7 additions
and
0 deletions
doc/git-howto.texi
+
7
−
0
View file @
97bf7c03
...
...
@@ -419,6 +419,13 @@ Also note that every single commit should pass the test suite, not just
the result of a series of patches. So if you have a series of commits
to push, run the test suite on every single commit.
Give other developers a reasonable amount of time to look at and review
patches before you push them. Not everybody is online 24/7, but may wish
to look at and comment on a patch nonetheless. The time you leave depends
on the urgency and complexity of the patch. Use your common sense to pick
a timeframe that allows everybody that you think may wish to comment
and/or should comment on the change an opportunity to see it.
Finally, after pushing, mark all patches as committed on
@url
{
http://patches.libav.org/,patchwork
}
.
Sometimes this is not automatically done when a patch has been
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment