Skip to content
Snippets Groups Projects
Commit 2cdba8bf authored by Diego Biurrun's avatar Diego Biurrun
Browse files

Add 'make checkheaders' to developer guidelines and patch checklist.

Originally committed as revision 15741 to svn://svn.ffmpeg.org/ffmpeg/trunk
parent ba26cfab
Branches
Tags
No related merge requests found
...@@ -951,6 +951,9 @@ should also be avoided if they don't make the code easier to understand. ...@@ -951,6 +951,9 @@ should also be avoided if they don't make the code easier to understand.
@item @item
If you add a new file, give it a proper license header. Do not copy and If you add a new file, give it a proper license header. Do not copy and
paste it from a random place, use an existing file as template. paste it from a random place, use an existing file as template.
@item
If you add a new header or change an existing one, make sure it passes
@code{make checkheaders}.
@end enumerate @end enumerate
We think our rules are not too hard. If you have comments, contact us. We think our rules are not too hard. If you have comments, contact us.
...@@ -1025,6 +1028,8 @@ do not attach several unrelated patches to the same mail. ...@@ -1025,6 +1028,8 @@ do not attach several unrelated patches to the same mail.
@enumerate @enumerate
@item @item
Do the regression tests pass with the patch applied? Do the regression tests pass with the patch applied?
@item
Does @code{make checkheaders} pass with the patch applied?
@item @item
Is the patch a unified diff? Is the patch a unified diff?
@item @item
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment