Better nil handling

Screenshottr/PomfManager.swift

@@ -19,7 +19,7 @@ class PomfManager {
             let userInfo: [AnyHashable : Any] = [
                 NSLocalizedDescriptionKey :  NSLocalizedString("Unsuccessful", value: "Go to Settings and enter a Pomf upload url.", comment: "") ,
                 ]
-            completionHandler(NSError(domain: "PomfErrorDomain", code: 1, userInfo: userInfo as? [String : Any]), "https://google.com")
+            completionHandler(NSError(domain: "PomfErrorDomain", code: 1, userInfo: userInfo as? [String : Any]), "https://whats-th.is")
             return
         }
         
@@ -49,27 +49,37 @@ class PomfManager {
                                 let description : String = parsedData["description"] as! String
                                 let userInfo: [AnyHashable : Any] = [
                                     NSLocalizedDescriptionKey :  NSLocalizedString("Unsuccessful", value: description, comment: "") ,
-                                    NSLocalizedFailureReasonErrorKey : NSLocalizedString("Unsuccessful", value: description, comment: "")
-                                ]
+                                    ]
                                 let errorCode : Int = parsedData["errorcode"] as! Int
-                                completionHandler(NSError(domain: "PomfErrorDomain", code: errorCode, userInfo: userInfo as? [String : Any]), "https://google.com")
+                                completionHandler(NSError(domain: "PomfErrorDomain", code: errorCode, userInfo: userInfo as? [String : Any]), "https://whats-th.is")
                                 return
                             }
                             
                             // Attempt to get information returned over the uploaded file.
-                            let test : [NSDictionary] = parsedData["files"] as! [NSDictionary]
-                            let furtherTest : NSDictionary = test[0]
-                            // https://discord.coffee/c58cec.png
-                            let fileName = furtherTest.object(forKey: "url") as! String? ?? "c58cec.png"
-                            completionHandler(nil, "\(defaults.string(forKey: "pomfBaseDomain")!)/\(fileName)" )
+                            let test = parsedData["files"] as! [NSDictionary]
+                            if let fileName : String = test[0]["url"] as? String {
+                                if let pomfBaseDomain = defaults.string(forKey: "pomfBaseDomain") {
+                                    completionHandler(nil, "\(pomfBaseDomain)!)/\(fileName)")
+                                } else {
+                                    let userInfo: [AnyHashable : Any] = [
+                                        NSLocalizedDescriptionKey :  NSLocalizedString("Unsuccessful", value: "Go to Settings and enter a Pomf base domain.", comment: "") ,
+                                        ]
+                                    completionHandler(NSError(domain: "PomfErrorDomain", code: 2, userInfo: userInfo as? [String : Any]), "https://whats-th.is")
+                                }
+                            } else {
+                                let userInfo: [AnyHashable : Any] = [
+                                    NSLocalizedDescriptionKey :  NSLocalizedString("Unsuccessful", value: "Could not parse returned filename.", comment: "") ,
+                                    ]
+                                completionHandler(NSError(domain: "PomfErrorDomain", code: 3, userInfo: userInfo as? [String : Any]), "https://whats-th.is")
+                            }
                         }
                     }
                 case .failure(let encodingError):
                     print(encodingError)
-                    completionHandler(encodingError, "https://google.com/")
+                    completionHandler(encodingError, "https://whats-th.is")
                 }
         }
-            )
-
+        )
+        
     }
 }