From 11175f6c60e2b414bf1047ba556c0c58ae519384 Mon Sep 17 00:00:00 2001
From: Shaun Wang <spxwang@gmail.com>
Date: Thu, 25 Mar 2021 13:11:09 +1300
Subject: [PATCH] Update orml-unknown-tokens unit tests. (#421)

---
 unknown-tokens/src/tests.rs | 18 ++++++------------
 1 file changed, 6 insertions(+), 12 deletions(-)

diff --git a/unknown-tokens/src/tests.rs b/unknown-tokens/src/tests.rs
index 395f803..63ad7a2 100644
--- a/unknown-tokens/src/tests.rs
+++ b/unknown-tokens/src/tests.rs
@@ -31,12 +31,6 @@ fn abstract_fungible(amount: u128) -> MultiAsset {
 	}
 }
 
-// `message` field of `DispatchError` would be gone after inserted into system
-// pallet storage.
-fn convert_err(err: DispatchError) -> DispatchError {
-	DispatchError::decode(&mut &err.encode()[..]).expect("encode then decode cannot fail")
-}
-
 #[test]
 fn deposit_concrete_fungible_asset_works() {
 	ExtBuilder.build().execute_with(|| {
@@ -60,7 +54,7 @@ fn deposit_concrete_fungible_asset_works() {
 		let deposit_failed_event = Event::unknown_tokens(crate::Event::DepositFailed(
 			max_asset,
 			MOCK_RECIPIENT,
-			convert_err(Error::<Runtime>::BalanceOverflow.into()),
+			Error::<Runtime>::BalanceOverflow.into(),
 		));
 		assert!(System::events()
 			.iter()
@@ -95,7 +89,7 @@ fn deposit_abstract_fungible_asset() {
 		let deposit_failed_event = Event::unknown_tokens(crate::Event::DepositFailed(
 			max_asset,
 			MOCK_RECIPIENT,
-			convert_err(Error::<Runtime>::BalanceOverflow.into()),
+			Error::<Runtime>::BalanceOverflow.into(),
 		));
 		assert!(System::events()
 			.iter()
@@ -114,7 +108,7 @@ fn deposit_unhandled_asset_should_fail() {
 		let deposit_failed_event = Event::unknown_tokens(crate::Event::DepositFailed(
 			MultiAsset::All,
 			MOCK_RECIPIENT,
-			convert_err(Error::<Runtime>::UnhandledAsset.into()),
+			Error::<Runtime>::UnhandledAsset.into(),
 		));
 		assert!(System::events()
 			.iter()
@@ -146,7 +140,7 @@ fn withdraw_concrete_fungible_asset_works() {
 		let withdraw_failed_event = Event::unknown_tokens(crate::Event::WithdrawFailed(
 			asset,
 			MOCK_RECIPIENT,
-			convert_err(Error::<Runtime>::BalanceTooLow.into()),
+			Error::<Runtime>::BalanceTooLow.into(),
 		));
 		assert!(System::events()
 			.iter()
@@ -178,7 +172,7 @@ fn withdraw_abstract_fungible_asset_works() {
 		let withdraw_failed_event = Event::unknown_tokens(crate::Event::WithdrawFailed(
 			asset,
 			MOCK_RECIPIENT,
-			convert_err(Error::<Runtime>::BalanceTooLow.into()),
+			Error::<Runtime>::BalanceTooLow.into(),
 		));
 		assert!(System::events()
 			.iter()
@@ -197,7 +191,7 @@ fn withdraw_unhandled_asset_should_fail() {
 		let withdraw_failed_event = Event::unknown_tokens(crate::Event::WithdrawFailed(
 			MultiAsset::All,
 			MOCK_RECIPIENT,
-			convert_err(Error::<Runtime>::UnhandledAsset.into()),
+			Error::<Runtime>::UnhandledAsset.into(),
 		));
 		assert!(System::events()
 			.iter()
-- 
GitLab