From cc5e4bb48476a89cc8ce0c41bc2bd2e8fda9b37c Mon Sep 17 00:00:00 2001
From: wm4 <nfxjfg@googlemail.com>
Date: Thu, 14 May 2015 18:27:31 +0200
Subject: [PATCH] hevc: make avcodec_decode_video2() fail if get_format() fails
Personally, I need the decoder to back out if get_format() returns no
usable pixel format. This didn't work because the error code was not
propagated down the call chain. This in turn happened because the
variable declaration removed in this patch shadowed the variable, whose
value is returned at the end of the function. Consequently, failures of
decode_nal_unit() were ignored in this place.
Reviewed-by: Andreas Cadhalpun <andreas.cadhalpun@googlemail.com>
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
---
libavcodec/hevc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/libavcodec/hevc.c b/libavcodec/hevc.c
index 459030c7e11..199a3b98506 100644
--- a/libavcodec/hevc.c
+++ b/libavcodec/hevc.c
@@ -3000,7 +3000,6 @@ static int decode_nal_units(HEVCContext *s, const uint8_t *buf, int length)
/* parse the NAL units */
for (i = 0; i < s->nb_nals; i++) {
- int ret;
s->skipped_bytes = s->skipped_bytes_nal[i];
s->skipped_bytes_pos = s->skipped_bytes_pos_nal[i];
--
GitLab