From bf868c4a9bc6c1ac4c4753822a7c652b7f7c8ff7 Mon Sep 17 00:00:00 2001
From: Mans Rullgard <mans@mansr.com>
Date: Mon, 15 Oct 2012 00:21:53 +0100
Subject: [PATCH] tiny_psnr: fix range calculation for sample size of 32 bits
For a sample size of 32 bits, the shift would overflow producing
undefined results. Incidentally, in the only test currently using
32-bit samples, the output matches the reference exactly on most
systems meaning the bad 'max' value is never used.
Signed-off-by: Mans Rullgard <mans@mansr.com>
---
tests/tiny_psnr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/tiny_psnr.c b/tests/tiny_psnr.c
index a53a67038bc..b1bcc166937 100644
--- a/tests/tiny_psnr.c
+++ b/tests/tiny_psnr.c
@@ -146,7 +146,7 @@ int main(int argc, char *argv[])
}
}
- max = (1 << (8 * len)) - 1;
+ max = (1LL << (8 * len)) - 1;
f[0] = fopen(argv[1], "rb");
f[1] = fopen(argv[2], "rb");
--
GitLab