From 7faafe606fb25e3c8b3091ea0565b01622c87dd2 Mon Sep 17 00:00:00 2001
From: Lukasz Marek <lukasz.m.luki@gmail.com>
Date: Tue, 4 Jun 2013 13:03:13 +0200
Subject: [PATCH] ftp: fix using uninitialized value
Fix coverity issue CID 1026777
Signed-off-by: Lukasz Marek <lukasz.m.luki@gmail.com>
---
libavformat/ftp.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/libavformat/ftp.c b/libavformat/ftp.c
index cd3006b495a..faa82dd30d5 100644
--- a/libavformat/ftp.c
+++ b/libavformat/ftp.c
@@ -265,7 +265,7 @@ static int ftp_auth(FTPContext *s)
static int ftp_passive_mode(FTPContext *s)
{
- char *res = NULL, *start, *end;
+ char *res = NULL, *start = NULL, *end = NULL;
int i;
const char *command = "PASV\r\n";
const int pasv_codes[] = {227, 501, 0}; /* 501 is incorrect code */
@@ -273,8 +273,7 @@ static int ftp_passive_mode(FTPContext *s)
if (ftp_send_command(s, command, pasv_codes, &res) != 227 || !res)
goto fail;
- start = NULL;
- for (i = 0; i < strlen(res); ++i) {
+ for (i = 0; res[i]; ++i) {
if (res[i] == '(') {
start = res + i + 1;
} else if (res[i] == ')') {
--
GitLab