From 6683a37f8988e80ea1c99c663a337647ffa3f307 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Diego=20Petten=C3=B2?= <flameeyes@gmail.com>
Date: Thu, 9 Oct 2008 11:10:30 +0000
Subject: [PATCH] Invert logic for the single-pass in swScale() functions.
Instead of having a firstTime variable defaulting to 1, have a
warnedAlready defaulting to 0. While this should make no difference in
code speed at runtime, it allows to aggregate the four bytes of that
variable with clip_table in .bss section, rather than issuing a .data
section just for that.
As it is, libswscale require no .data section but .data.rel.ro (that
can be mitigated by prelinking), so the change might actually save one
page of memory at runtime (per process).
Originally committed as revision 27734 to svn://svn.mplayerhq.hu/mplayer/trunk/libswscale
---
libswscale/swscale_template.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/libswscale/swscale_template.c b/libswscale/swscale_template.c
index 4d8a4434ee6..30075f60277 100644
--- a/libswscale/swscale_template.c
+++ b/libswscale/swscale_template.c
@@ -2964,12 +2964,12 @@ static int RENAME(swScale)(SwsContext *c, uint8_t* src[], int srcStride[], int s
if (dstStride[0]%8 !=0 || dstStride[1]%8 !=0 || dstStride[2]%8 !=0)
{
- static int firstTime=1; //FIXME move this into the context perhaps
- if (flags & SWS_PRINT_INFO && firstTime)
+ static int warnedAlready=0; //FIXME move this into the context perhaps
+ if (flags & SWS_PRINT_INFO && !warnedAlready)
{
av_log(c, AV_LOG_WARNING, "Warning: dstStride is not aligned!\n"
" ->cannot do aligned memory accesses anymore\n");
- firstTime=0;
+ warnedAlready=1;
}
}
--
GitLab