From 5f2b360fc05bbb4f21e1247d1d9af303113d6c25 Mon Sep 17 00:00:00 2001
From: Michael Niedermayer <michael@niedermayer.cc>
Date: Sat, 21 Jan 2017 01:35:52 +0100
Subject: [PATCH] avfilter/avfiltergraph: Add assert to write down in machine
readable form what is assumed about sample rates in
swap_samplerates_on_filter()
Fixes CID1397292
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
---
libavfilter/avfiltergraph.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/libavfilter/avfiltergraph.c b/libavfilter/avfiltergraph.c
index 97f242ebecc..534c6701a84 100644
--- a/libavfilter/avfiltergraph.c
+++ b/libavfilter/avfiltergraph.c
@@ -876,6 +876,8 @@ static void swap_samplerates_on_filter(AVFilterContext *filter)
for (j = 0; j < outlink->in_samplerates->nb_formats; j++) {
int diff = abs(sample_rate - outlink->in_samplerates->formats[j]);
+ av_assert0(diff < INT_MAX); // This would lead to the use of uninitialized best_diff but is only possible with invalid sample rates
+
if (diff < best_diff) {
best_diff = diff;
best_idx = j;
--
GitLab